# HG changeset patch # User rubidium # Date 1217855715 0 # Node ID b1056419429f0603529f8a246528a8c384079dc7 # Parent 705fc23bedba69961e50907f2c4ae58e8166e74b (svn r13989) -Fix [FS#2186] (r13953): YAPP track reservation for crashed trains was broken for depots and wormholes (michi_cc). diff -r 705fc23bedba -r b1056419429f src/train_cmd.cpp --- a/src/train_cmd.cpp Mon Aug 04 12:56:38 2008 +0000 +++ b/src/train_cmd.cpp Mon Aug 04 13:15:15 2008 +0000 @@ -3436,6 +3436,11 @@ FreeTrainTrackReservation(v); for (const Vehicle *u = v; u != NULL; u = u->Next()) { ClearPathReservation(u->tile, GetVehicleTrackdir(u)); + if (IsTileType(u->tile, MP_TUNNELBRIDGE)) { + /* ClearPathReservation will not free the wormhole exit + * if the train has just entered the wormhole. */ + SetTunnelBridgeReservation(GetOtherTunnelBridgeEnd(u->tile), false); + } } } @@ -3511,7 +3516,12 @@ * As there might be more than two trains involved, we have to do that for all vehicles */ const Vehicle *u; FOR_ALL_VEHICLES(u) { - if (u->type == VEH_TRAIN && HASBITS(u->vehstatus, VS_CRASHED)) { + if (u->type == VEH_TRAIN && HASBITS(u->vehstatus, VS_CRASHED) && (u->u.rail.track & TRACK_BIT_DEPOT) == TRACK_BIT_NONE) { + TrackBits trackbits = u->u.rail.track; + if ((trackbits & TRACK_BIT_WORMHOLE) == TRACK_BIT_WORMHOLE) { + /* Vehicle is inside a wormhole, v->u.rail.track contains no useful value then. */ + trackbits |= DiagDirToDiagTrackBits(GetTunnelBridgeDirection(u->tile)); + } TryReserveRailTrack(u->tile, TrackBitsToTrack(u->u.rail.track)); } } @@ -3843,7 +3853,14 @@ { TrackBits *trackbits = (TrackBits *)data; - if (v->type == VEH_TRAIN && (v->vehstatus & VS_CRASHED) != 0) *trackbits |= v->u.rail.track; + if (v->type == VEH_TRAIN && (v->vehstatus & VS_CRASHED) != 0) { + if ((v->u.rail.track & TRACK_BIT_WORMHOLE) == TRACK_BIT_WORMHOLE) { + /* Vehicle is inside a wormhole, v->u.rail.track contains no useful value then. */ + *trackbits |= DiagDirToDiagTrackBits(GetTunnelBridgeDirection(v->tile)); + } else { + *trackbits |= v->u.rail.track; + } + } return NULL; } @@ -3886,13 +3903,18 @@ /* 'v' shouldn't be accessed after it has been deleted */ TrackBits trackbits = v->u.rail.track; - Track track = TrackBitsToTrack(trackbits); TileIndex tile = v->tile; Owner owner = v->owner; delete v; v = NULL; // make sure nobody will try to read 'v' anymore + if ((trackbits & TRACK_BIT_WORMHOLE) == TRACK_BIT_WORMHOLE) { + /* Vehicle is inside a wormhole, v->u.rail.track contains no useful value then. */ + trackbits |= DiagDirToDiagTrackBits(GetTunnelBridgeDirection(tile)); + } + + Track track = TrackBitsToTrack(trackbits); if (HasReservedTracks(tile, trackbits)) { UnreserveRailTrack(tile, track);