# HG changeset patch # User rubidium # Date 1228500124 0 # Node ID fb6f4c4476a6cf5276c24fd56668823a011c1e07 # Parent ea3784c0b3dd482273d0375469da61d0c36158e6 (svn r14656) -Change: replace instances of x & S_IFREG with S_ISREG(x) as S_IFREG can be 0 on some platforms. diff -r ea3784c0b3dd -r fb6f4c4476a6 src/fileio.cpp --- a/src/fileio.cpp Thu Dec 04 18:47:20 2008 +0000 +++ b/src/fileio.cpp Fri Dec 05 18:02:04 2008 +0000 @@ -711,12 +711,12 @@ snprintf(filename, lengthof(filename), "%s%s", path, d_name); - if (sb.st_mode & S_IFDIR) { + if (S_ISDIR(sb.st_mode)) { /* Directory */ if (strcmp(d_name, ".") == 0 || strcmp(d_name, "..") == 0) continue; AppendPathSeparator(filename, lengthof(filename)); num += ScanPathForTarFiles(filename, basepath_length); - } else if (sb.st_mode & S_IFREG) { + } else if (S_ISREG(sb.st_mode)) { /* File */ char *ext = strrchr(filename, '.'); diff -r ea3784c0b3dd -r fb6f4c4476a6 src/fios.cpp --- a/src/fios.cpp Thu Dec 04 18:47:20 2008 +0000 +++ b/src/fios.cpp Fri Dec 05 18:02:04 2008 +0000 @@ -226,7 +226,7 @@ strecpy(d_name, FS2OTTD(dirent->d_name), lastof(d_name)); /* found file must be directory, but not '.' or '..' */ - if (FiosIsValidFile(_fios_path, dirent, &sb) && (sb.st_mode & S_IFDIR) && + if (FiosIsValidFile(_fios_path, dirent, &sb) && S_ISDIR(sb.st_mode) && (!FiosIsHiddenFile(dirent) || strncasecmp(d_name, PERSONAL_DIR, strlen(d_name)) == 0) && strcmp(d_name, ".") != 0 && strcmp(d_name, "..") != 0) { fios = _fios_items.Append(); @@ -259,7 +259,7 @@ char *t; strecpy(d_name, FS2OTTD(dirent->d_name), lastof(d_name)); - if (!FiosIsValidFile(_fios_path, dirent, &sb) || !(sb.st_mode & S_IFREG) || FiosIsHiddenFile(dirent)) continue; + if (!FiosIsValidFile(_fios_path, dirent, &sb) || !S_ISREG(sb.st_mode) || FiosIsHiddenFile(dirent)) continue; /* File has no extension, skip it */ if ((t = strrchr(d_name, '.')) == NULL) continue;