Sun, 18 May 2008 11:25:04 +0000(svn r13157) [NoAI] -Fix: in general it is considered VERY VERY VERY REALLY REALLY bad to delete a class instance from a function inside that class itself. noai
truebrain [Sun, 18 May 2008 11:25:04 +0000] rev 10613
(svn r13157) [NoAI] -Fix: in general it is considered VERY VERY VERY REALLY REALLY bad to delete a class instance from a function inside that class itself.
His surrounding is never informed of this 'action', and they all of a sudden have an invalid pointer, causing all kinds of cool and magic effects (read: random crashes all over the place).
It might be a REALLY good idea to leave cleaning up of a class instances to the creator of that instance.
If you want to cleanup the saveload thread, make a garbage collector. More things use threads (like fibers). Deleting a class like this is bad, worse, worst!!!! !! !!! !!!!! and should be avoided AT ALL COSTS!

Sun, 18 May 2008 11:23:41 +0000(svn r13156) -Codechange: make classes of the GraphWindows.
rubidium [Sun, 18 May 2008 11:23:41 +0000] rev 10612
(svn r13156) -Codechange: make classes of the GraphWindows.

Sun, 18 May 2008 09:39:40 +0000(svn r13155) -Codechange: make a window class of the company league and graph legenda windows.
rubidium [Sun, 18 May 2008 09:39:40 +0000] rev 10611
(svn r13155) -Codechange: make a window class of the company league and graph legenda windows.

Sun, 18 May 2008 08:50:51 +0000(svn r13154) -Codechange: make a window class of the news message history window.
rubidium [Sun, 18 May 2008 08:50:51 +0000] rev 10610
(svn r13154) -Codechange: make a window class of the news message history window.

Sun, 18 May 2008 08:13:13 +0000(svn r13153) -Codechange: make classes of the TownViewWindow and the ScenarioEditorTownGenerationWindow.
rubidium [Sun, 18 May 2008 08:13:13 +0000] rev 10609
(svn r13153) -Codechange: make classes of the TownViewWindow and the ScenarioEditorTownGenerationWindow.

Sun, 18 May 2008 08:12:29 +0000(svn r13152) -Codechange: make a class of the subsidy window.
rubidium [Sun, 18 May 2008 08:12:29 +0000] rev 10608
(svn r13152) -Codechange: make a class of the subsidy window.

Sat, 17 May 2008 23:11:06 +0000(svn r13151) -Codechange: use an enum instead of bool as return type of OnKeyPress/OnCTRLStateChange to make it obvious what the return values mean.
rubidium [Sat, 17 May 2008 23:11:06 +0000] rev 10607
(svn r13151) -Codechange: use an enum instead of bool as return type of OnKeyPress/OnCTRLStateChange to make it obvious what the return values mean.

Sat, 17 May 2008 22:52:51 +0000(svn r13150) -Codechange: make classes of the Music[TrackSelection]Window.
glx [Sat, 17 May 2008 22:52:51 +0000] rev 10606
(svn r13150) -Codechange: make classes of the Music[TrackSelection]Window.

Sat, 17 May 2008 22:07:04 +0000(svn r13149) -Codechange: make a class of the BuildBridgeWindow.
skidd13 [Sat, 17 May 2008 22:07:04 +0000] rev 10605
(svn r13149) -Codechange: make a class of the BuildBridgeWindow.

Sat, 17 May 2008 21:20:58 +0000(svn r13148) -Codechange: make a class of the SelectGameWindow.
glx [Sat, 17 May 2008 21:20:58 +0000] rev 10604
(svn r13148) -Codechange: make a class of the SelectGameWindow.