diff -r d5923d3fa08c -r f666f6b62978 train_cmd.c --- a/train_cmd.c Thu Jun 28 13:58:39 2007 +0000 +++ b/train_cmd.c Thu Jun 28 14:11:00 2007 +0000 @@ -2748,26 +2748,28 @@ static byte AfterSetTrainPos(Vehicle *v, bool new_tile) { - byte new_z, old_z; - - // need this hint so it returns the right z coordinate on bridges. - _get_z_hint = v->z_pos; - new_z = GetSlopeZ(v->x_pos, v->y_pos); - _get_z_hint = 0; - - old_z = v->z_pos; - v->z_pos = new_z; + byte old_z = v->z_pos; + v->z_pos = GetSlopeZ(v->x_pos, v->y_pos); if (new_tile) { CLRBIT(v->u.rail.flags, VRF_GOINGUP); CLRBIT(v->u.rail.flags, VRF_GOINGDOWN); - if (new_z != old_z) { - TileIndex tile = TileVirtXY(v->x_pos, v->y_pos); - - // XXX workaround, whole UP/DOWN detection needs overhaul - if (!IsTunnelTile(tile)) { - SETBIT(v->u.rail.flags, (new_z > old_z) ? VRF_GOINGUP : VRF_GOINGDOWN); + if (v->u.rail.track == TRACK_BIT_X || v->u.rail.track == TRACK_BIT_Y) { + /* Any track that isn't TRACK_BIT_X or TRACK_BIT_Y cannot be sloped. + * To check whether the current tile is sloped, and in which + * direction it is sloped, we get the 'z' at the center of + * the tile (middle_z) and the edge of the tile (old_z), + * which we then can compare. */ + static const int HALF_TILE_SIZE = TILE_SIZE / 2; + static const int INV_TILE_SIZE_MASK = ~(TILE_SIZE - 1); + + byte middle_z = GetSlopeZ((v->x_pos & INV_TILE_SIZE_MASK) | HALF_TILE_SIZE, (v->y_pos & INV_TILE_SIZE_MASK) | HALF_TILE_SIZE); + + /* For some reason tunnel tiles are always given as sloped :( + * But they are not sloped... */ + if (middle_z != v->z_pos && !IsTunnelTile(TileVirtXY(v->x_pos, v->y_pos))) { + SETBIT(v->u.rail.flags, (middle_z > old_z) ? VRF_GOINGUP : VRF_GOINGDOWN); } } }