# HG changeset patch # User belugas # Date 1188258656 0 # Node ID 0782afa40e4a242dfea2b17d94c55f78a2ad41df # Parent b10b1a884892d8e5cfa71517d80b2be0cc7c92d2 (svn r10993) -Codechange: A few less magical numbers (skidd13) diff -r b10b1a884892 -r 0782afa40e4a src/town_cmd.cpp --- a/src/town_cmd.cpp Mon Aug 27 21:33:26 2007 +0000 +++ b/src/town_cmd.cpp Mon Aug 27 23:50:56 2007 +0000 @@ -672,7 +672,7 @@ /* No, try to build one in the direction. * if that fails clear the land, and if that fails exit. * This is to make sure that we can build a road here later. */ - if (CmdFailed(DoCommand(tile, (dir & 1 ? ROAD_X : ROAD_Y), 0, DC_AUTO, CMD_BUILD_ROAD)) && + if (CmdFailed(DoCommand(tile, (dir & ROAD_NW ? ROAD_X : ROAD_Y), 0, DC_AUTO, CMD_BUILD_ROAD)) && CmdFailed(DoCommand(tile, 0, 0, DC_AUTO, CMD_LANDSCAPE_CLEAR))) return false; } @@ -695,7 +695,7 @@ /* If the tile is not a slope in the right direction, then * maybe terraform some. */ - k = (dir & 1) ? SLOPE_NE : SLOPE_NW; + k = (dir & ROAD_NW) ? SLOPE_NE : SLOPE_NW; if (k != slope && ComplementSlope(k) != slope) { uint32 r = Random(); @@ -939,7 +939,7 @@ * at any side of the new road. */ } - rcmd = (RoadBits)((1 << a) + (1 << b)); + rcmd = (RoadBits)((ROAD_NW << a) + (ROAD_NW << b)); break; } @@ -961,7 +961,7 @@ case TL_BETTER_ROADS: case TL_ORIGINAL: - rcmd = (RoadBits)(1 << (block ^ 2)); + rcmd = (RoadBits)(ROAD_NW << (block ^ 2)); break; } } else { @@ -1040,7 +1040,7 @@ } _grow_town_result = 0; - rcmd = (RoadBits)(1 << i); + rcmd = (RoadBits)(ROAD_NW << i); } /* Return if a water tile */ @@ -1138,7 +1138,7 @@ /* Exclude the source position from the bitmask * and return if no more road blocks available */ ClrBitT(mask, (block ^ 2)); - if (mask == 0) + if (mask == ROAD_NONE) return _grow_town_result; /* Select a random bit from the blockmask, walk a step