# HG changeset patch # User tron # Date 1145040728 0 # Node ID 5887de7bd4ee9ffb9a4e5398f158dee14760c4a6 # Parent 305bfac8b7d864a97cf06e453b4ddc65479c9cf4 (svn r4416) Remove a pointless buffer copy and use strlcpy() instead of snprintf("%s") diff -r 305bfac8b7d8 -r 5887de7bd4ee network_udp.c --- a/network_udp.c Fri Apr 14 16:28:24 2006 +0000 +++ b/network_udp.c Fri Apr 14 18:52:08 2006 +0000 @@ -549,15 +549,12 @@ struct sockaddr_in out_addr; Packet *p; NetworkGameList *item; - char hostname[NETWORK_HOSTNAME_LENGTH]; // No UDP-socket yet.. if (_udp_client_socket == INVALID_SOCKET) if (!NetworkUDPListen(&_udp_client_socket, 0, 0, true)) return NULL; - ttd_strlcpy(hostname, host, sizeof(hostname)); - out_addr.sin_family = AF_INET; out_addr.sin_port = htons(port); out_addr.sin_addr.s_addr = NetworkResolveHost(host); @@ -565,8 +562,8 @@ // Clear item in gamelist item = NetworkGameListAddItem(inet_addr(inet_ntoa(out_addr.sin_addr)), ntohs(out_addr.sin_port)); memset(&item->info, 0, sizeof(item->info)); - snprintf(item->info.server_name, sizeof(item->info.server_name), "%s", hostname); - snprintf(item->info.hostname, sizeof(item->info.hostname), "%s", hostname); + ttd_strlcpy(item->info.server_name, host, lengthof(item->info.server_name)); + ttd_strlcpy(item->info.hostname, host, lengthof(item->info.hostname)); item->online = false; // Init the packet