# HG changeset patch # User maedhros # Date 1176721175 0 # Node ID 8b595fca657f5fc6d4e9e918d79a1ee9a558a62c # Parent d8e51011b51d25d54a1b0b424260326fc6de1e83 (svn r9648) -Codechange: Use HASBIT directly rather than shifting and then using it on the first bit. diff -r d8e51011b51d -r 8b595fca657f src/settings_gui.cpp --- a/src/settings_gui.cpp Mon Apr 16 10:30:31 2007 +0000 +++ b/src/settings_gui.cpp Mon Apr 16 10:59:35 2007 +0000 @@ -325,13 +325,6 @@ { 0, 2, 1, STR_6839_PERMISSIVE}, }; -static inline bool GetBitAndShift(uint32 *b) -{ - uint32 x = *b; - *b >>= 1; - return HASBIT(x, 0); -} - /* * A: competitors * B: start time in months / 3 @@ -430,9 +423,9 @@ y = GAMEDIFF_WND_TOP_OFFSET; for (i = 0; i != GAME_DIFFICULTY_NUM; i++) { - DrawFrameRect( 5, y, 5 + 8, y + 8, 3, GetBitAndShift(&click_a) ? FR_LOWERED : FR_NONE); - DrawFrameRect(15, y, 15 + 8, y + 8, 3, GetBitAndShift(&click_b) ? FR_LOWERED : FR_NONE); - if (GetBitAndShift(&disabled) || (_networking && !_network_server)) { + DrawFrameRect( 5, y, 5 + 8, y + 8, 3, HASBIT(click_a, i) ? FR_LOWERED : FR_NONE); + DrawFrameRect(15, y, 15 + 8, y + 8, 3, HASBIT(click_b, i) ? FR_LOWERED : FR_NONE); + if (HASBIT(disabled, i) || (_networking && !_network_server)) { int color = (1 << PALETTE_MODIFIER_GREYOUT) | _colour_gradient[COLOUR_YELLOW][2]; GfxFillRect( 6, y + 1, 6 + 8, y + 8, color); GfxFillRect(16, y + 1, 16 + 8, y + 8, color);