# HG changeset patch
# User ludde
# Date 1121625407 0
# Node ID c3202f3988dfe5e2a2cde3f9d58679a573326c61
# Parent  56fb33886585ce9bf7b9ae297582efd7b94df73b
(svn r2619) Fix: [viewport] Fix potential buffer overflow reported by Tron

diff -r 56fb33886585 -r c3202f3988df viewport.c
--- a/viewport.c	Sun Jul 17 18:20:55 2005 +0000
+++ b/viewport.c	Sun Jul 17 18:36:47 2005 +0000
@@ -61,6 +61,10 @@
 	byte tile_z_bottom;
 } ParentSpriteToDraw;
 
+// Quick hack to know how much memory to reserve when allocating from the spritelist
+// to prevent a buffer overflow.
+#define LARGEST_SPRITELIST_STRUCT ParentSpriteToDraw
+
 typedef struct ViewportDrawer {
 	DrawPixelInfo dpi;
 
@@ -1236,7 +1240,7 @@
 	vd.parent_list = parent_list;
 	vd.eof_parent_list = &parent_list[lengthof(parent_list)];
 	vd.spritelist_mem = mem;
-	vd.eof_spritelist_mem = &mem[sizeof(mem) - 0x40];
+	vd.eof_spritelist_mem = &mem[sizeof(mem) - sizeof(LARGEST_SPRITELIST_STRUCT)];
 	vd.last_string = &vd.first_string;
 	vd.first_string = NULL;
 	vd.last_tile = &vd.first_tile;