# HG changeset patch # User tron # Date 1121593288 0 # Node ID dbe5faa270e060225fbd9602a7c6c97ce1e625e9 # Parent ae9e92ffe168877c1c9d91ea86687c888fd4329e (svn r2596) Add macros ROL and ROR to ROtate values Left/Right. Also shorten the parameter names for GB and SB to increase readability diff -r ae9e92ffe168 -r dbe5faa270e0 macros.h --- a/macros.h Sat Jul 16 23:47:37 2005 +0000 +++ b/macros.h Sun Jul 17 09:41:28 2005 +0000 @@ -153,9 +153,16 @@ } #endif -// Fetch count bits starting at bit start from value -#define GB(value, start, count) (((value) >> (start)) & ((1 << (count)) - 1)) -// Set count bits in value starting at bit start to data -#define SB(value, start, count, data) ((value) = ((value) & ~(((1 << (count)) - 1) << (start))) | ((data) << (start))) +/// Fetch n bits starting at bit s from x +#define GB(x, s, n) (((x) >> (s)) & ((1 << (n)) - 1)) +/// Set n bits in x starting at bit s to d +#define SB(x, s, n, d) ((x) = ((x) & ~(((1 << (n)) - 1) << (s))) | ((d) << (s))) + +/** + * ROtate x Left/Right by n (must be >= 0) + * @note Assumes a byte has 8 bits + */ +#define ROL(x, n) ((x) << (n) | (x) >> (sizeof(x) * 8 - (n))) +#define ROR(x, n) ((x) >> (n) | (x) << (sizeof(x) * 8 - (n))) #endif /* MACROS_H */ diff -r ae9e92ffe168 -r dbe5faa270e0 misc.c --- a/misc.c Sat Jul 16 23:47:37 2005 +0000 +++ b/misc.c Sun Jul 17 09:41:28 2005 +0000 @@ -19,11 +19,6 @@ char _name_array[512][32]; -static inline uint32 ROR(uint32 x, int n) -{ - return (x >> n) + (x << ((sizeof(x)*8)-n)); -} - #ifndef MERSENNE_TWISTER #ifdef RANDOM_DEBUG