(svn r11332) -Fix: vehicles getting a value of 0 on construction.
-Fix: assertion when selling vehicles.
--- a/src/aircraft_cmd.cpp Sun Oct 21 16:44:19 2007 +0000
+++ b/src/aircraft_cmd.cpp Sun Oct 21 16:45:00 2007 +0000
@@ -299,9 +299,9 @@
Vehicle *v = vl[0]; // aircraft
Vehicle *u = vl[1]; // shadow
- v->unitnumber = unit_num;
v = new (v) Aircraft();
u = new (u) Aircraft();
+ v->unitnumber = unit_num;
v->direction = DIR_SE;
v->owner = u->owner = _current_player;
@@ -491,13 +491,15 @@
SET_EXPENSES_TYPE(EXPENSES_NEW_VEHICLES);
+ CommandCost ret(-v->value);
+
if (flags & DC_EXEC) {
// Invalidate depot
InvalidateWindow(WC_VEHICLE_DEPOT, v->tile);
DoDeleteAircraft(v);
}
- return CommandCost(-v->value);
+ return ret;
}
/** Start/Stop an aircraft.
--- a/src/roadveh_cmd.cpp Sun Oct 21 16:44:19 2007 +0000
+++ b/src/roadveh_cmd.cpp Sun Oct 21 16:45:00 2007 +0000
@@ -202,6 +202,7 @@
const RoadVehicleInfo *rvi = RoadVehInfo(p1);
+ v = new (v) RoadVehicle();
v->unitnumber = unit_num;
v->direction = DiagDirToDir(GetRoadDepotDirection(tile));
v->owner = _current_player;
@@ -247,7 +248,6 @@
v->date_of_last_service = _date;
v->build_year = _cur_year;
- v = new (v) RoadVehicle();
v->cur_image = 0xC15;
v->random_bits = VehicleRandomBits();
SetRoadVehFront(v);
--- a/src/ship_cmd.cpp Sun Oct 21 16:44:19 2007 +0000
+++ b/src/ship_cmd.cpp Sun Oct 21 16:45:00 2007 +0000
@@ -835,6 +835,7 @@
const ShipVehicleInfo *svi = ShipVehInfo(p1);
+ v = new (v) Ship();
v->unitnumber = unit_num;
v->owner = _current_player;
@@ -871,7 +872,6 @@
v->date_of_last_service = _date;
v->build_year = _cur_year;
v->cur_image = 0x0E5E;
- v = new (v) Ship();
v->random_bits = VehicleRandomBits();
v->vehicle_flags = 0;
@@ -919,6 +919,8 @@
return_cmd_error(STR_980B_SHIP_MUST_BE_STOPPED_IN);
}
+ CommandCost ret(-v->value);
+
if (flags & DC_EXEC) {
InvalidateWindow(WC_VEHICLE_DEPOT, v->tile);
RebuildVehicleLists();
@@ -928,7 +930,7 @@
delete v;
}
- return CommandCost(-v->value);
+ return ret;
}
/** Start/Stop a ship.
--- a/src/train_cmd.cpp Sun Oct 21 16:44:19 2007 +0000
+++ b/src/train_cmd.cpp Sun Oct 21 16:45:00 2007 +0000
@@ -540,6 +540,7 @@
}
}
+ v = new (v) Train();
v->engine_type = engine;
DiagDirection dir = GetRailDepotDirection(tile);
@@ -557,7 +558,6 @@
v->u.rail.track = TRACK_BIT_DEPOT;
v->vehstatus = VS_HIDDEN | VS_DEFPAL;
- v = new (v) Train();
v->subtype = 0;
SetTrainWagon(v);