(svn r1365) -Fix: very, very nasty buffer overflow bug introduced with replace vehicles. You CANNOT access the i[255] of an array that only has 255 elements! I will kick the next person that does that so hard...goddammit (I only noticed it because it screwed up my console in the debug build and took me at least an hour to fix)
authordarkvater
Tue, 04 Jan 2005 00:07:58 +0000
changeset 880 f3d9b97fff06
parent 879 c10172705487
child 881 02fdb6abf338
(svn r1365) -Fix: very, very nasty buffer overflow bug introduced with replace vehicles. You CANNOT access the i[255] of an array that only has 255 elements! I will kick the next person that does that so hard...goddammit (I only noticed it because it screwed up my console in the debug build and took me at least an hour to fix)
misc.c
--- a/misc.c	Mon Jan 03 22:16:02 2005 +0000
+++ b/misc.c	Tue Jan 04 00:07:58 2005 +0000
@@ -185,9 +185,9 @@
 {
 	// Initialize the autoreplace array. Needs to be cleared between each game
 	int i;
-	for (i = 0; i < 256; i++) {
+	for (i = 0; i < lengthof(_autoreplace_array); i++)
 		_autoreplace_array[i] = i;
-	}
+
 	AddTypeToEngines(); // make sure all engines have a type
 	
 	SetObjectToPlace(1, 0, 0, 0);