(svn r13775) -Codechange: enforce the validity of a NetworkAction (chat packet) issued by a client
authorglx
Mon, 21 Jul 2008 15:50:55 +0000
changeset 9675 f76b3b37bf5a
parent 9674 3d401a3233e2
child 9676 8339e7fc7708
(svn r13775) -Codechange: enforce the validity of a NetworkAction (chat packet) issued by a client
src/network/network_server.cpp
--- a/src/network/network_server.cpp	Mon Jul 21 14:42:25 2008 +0000
+++ b/src/network/network_server.cpp	Mon Jul 21 15:50:55 2008 +0000
@@ -1166,7 +1166,21 @@
 
 	p->Recv_string(msg, MAX_TEXT_MSG_LEN);
 
-	NetworkServerSendChat(action, desttype, dest, msg, cs->index);
+	const NetworkClientInfo *ci = DEREF_CLIENT_INFO(cs);
+	switch (action) {
+		case NETWORK_ACTION_GIVE_MONEY:
+			if (!IsValidPlayerID(ci->client_playas)) break;
+			/* Fall-through */
+		case NETWORK_ACTION_CHAT:
+		case NETWORK_ACTION_CHAT_CLIENT:
+		case NETWORK_ACTION_CHAT_COMPANY:
+			NetworkServerSendChat(action, desttype, dest, msg, cs->index);
+			break;
+		default:
+			IConsolePrintF(CC_ERROR, "WARNING: invalid chat action from client %d (IP: %s).", ci->client_index, GetPlayerIP(ci));
+			SEND_COMMAND(PACKET_SERVER_ERROR)(cs, NETWORK_ERROR_NOT_EXPECTED);
+			break;
+	}
 }
 
 DEF_SERVER_RECEIVE_COMMAND(PACKET_CLIENT_SET_PASSWORD)