(svn r11601) -Codechange: more strict break conditions for _userstring, assert when it overflows anyway (eg. code change without proper check change)
--- a/src/misc_gui.cpp Sat Dec 08 15:47:23 2007 +0000
+++ b/src/misc_gui.cpp Sat Dec 08 18:50:39 2007 +0000
@@ -772,7 +772,7 @@
b = InlineString(b, STR_000D_ACCEPTS);
for (CargoID i = 0; i < NUM_CARGO; i++) {
- if (b >= lastof(_userstring) - 5) break;
+ if (b >= lastof(_userstring) - (1 + 2 * 4)) break; // ',' or ' ' and two calls to Utf8Encode()
switch (sct) {
case SCT_PASSENGERS_ONLY: if (!IsCargoInClass(i, CC_PASSENGERS)) continue; break;
case SCT_NON_PASSENGERS_ONLY: if (IsCargoInClass(i, CC_PASSENGERS)) continue; break;
@@ -795,6 +795,10 @@
if (first) b = InlineString(b, STR_00D0_NOTHING);
*b = '\0';
+
+ /* Make sure we detect any buffer overflow */
+ assert(b < endof(_userstring));
+
DrawStringMultiLine(str_x, str_y, STR_SPEC_USERSTRING, 144);
}
--- a/src/station_gui.cpp Sat Dec 08 15:47:23 2007 +0000
+++ b/src/station_gui.cpp Sat Dec 08 18:50:39 2007 +0000
@@ -807,7 +807,7 @@
b = InlineString(b, STR_000C_ACCEPTS);
for (CargoID i = 0; i < NUM_CARGO; i++) {
- if (b >= endof(_userstring) - 5 - 1) break;
+ if (b >= lastof(_userstring) - (1 + 2 * 4)) break; // ',' or ' ' and two calls to Utf8Encode()
if (HasBit(st->goods[i].acceptance_pickup, GoodsEntry::ACCEPTANCE)) {
if (first) {
first = false;
@@ -824,6 +824,10 @@
if (first) b = InlineString(b, STR_00D0_NOTHING);
*b = '\0';
+
+ /* Make sure we detect any buffer overflow */
+ assert(b < endof(_userstring));
+
DrawStringMultiLine(2, 67, STR_SPEC_USERSTRING, 245);
} else { // extended window with list of cargo ratings
DrawString(2, 67, STR_3034_LOCAL_RATING_OF_TRANSPORT, TC_FROMSTRING);
--- a/src/vehicle_gui.cpp Sat Dec 08 15:47:23 2007 +0000
+++ b/src/vehicle_gui.cpp Sat Dec 08 18:50:39 2007 +0000
@@ -506,6 +506,8 @@
for (CargoID cid = 0; cid < NUM_CARGO; cid++) {
if (!HasBit(cmask, cid)) continue;
+ if (b >= lastof(_userstring) - (2 + 2 * 4)) break; // ", " and two calls to Utf8Encode()
+
if (!first) b = strecpy(b, ", ", lastof(_userstring));
first = false;
@@ -515,6 +517,10 @@
/* Terminate and display the completed string */
*b = '\0';
+
+ /* Make sure we detect any buffer overflow */
+ assert(b < endof(_userstring));
+
return DrawStringMultiLine(x, y, STR_SPEC_USERSTRING, w);
}