(svn r4777) - NewGRF: moving warning message about feature callbacks above station code and change minimum length for action 3 from 7 to 6 bytes.
authorpeter1138
Sun, 07 May 2006 17:43:03 +0000
changeset 3783 17a76f40e236
parent 3782 89858a50ee93
child 3784 41d43d1191a5
(svn r4777) - NewGRF: moving warning message about feature callbacks above station code and change minimum length for action 3 from 7 to 6 bytes.
newgrf.c
--- a/newgrf.c	Sun May 07 16:34:16 2006 +0000
+++ b/newgrf.c	Sun May 07 17:43:03 2006 +0000
@@ -1559,11 +1559,19 @@
 	uint8 cidcount;
 	int c, i;
 
-	check_length(len, 7, "VehicleMapSpriteGroup");
+	check_length(len, 6, "VehicleMapSpriteGroup");
 	feature = buf[1];
 	idcount = buf[2] & 0x7F;
 	wagover = (buf[2] & 0x80) == 0x80;
 	check_length(len, 3 + idcount, "VehicleMapSpriteGroup");
+
+	/* If ``n-id'' (or ``idcount'') is zero, this is a ``feature
+	 * callback''. */
+	if (idcount == 0) {
+		grfmsg(GMS_WARN, "VehicleMapSpriteGroup: Feature callbacks not implemented yet.");
+		return;
+	}
+
 	cidcount = buf[3 + idcount];
 	check_length(len, 4 + idcount + cidcount * 3, "VehicleMapSpriteGroup");
 
@@ -1625,15 +1633,6 @@
 		return;
 	}
 
-
-	/* If ``n-id'' (or ``idcount'') is zero, this is a ``feature
-	 * callback''. I have no idea how this works, so we will ignore it for
-	 * now.  --octo */
-	if (idcount == 0) {
-		grfmsg(GMS_NOTICE, "NewMapping: Feature callbacks not implemented yet.");
-		return;
-	}
-
 	// FIXME: Tropicset contains things like:
 	// 03 00 01 19 01 00 00 00 00 - this is missing one 00 at the end,
 	// what should we exactly do with that? --pasky