(svn r8843) -Fix
authortron
Thu, 22 Feb 2007 15:01:38 +0000
changeset 6433 84cd6e4262fd
parent 6432 8fb778a7f2d7
child 6434 d12a3ab5acbc
(svn r8843) -Fix

-Fix: Off-by-one error in accessing a buffer (if you start at the second byte you have to subtract one from the size)
Also avoid an unnecessary buffer copy and strlcpy() abuse
NOTE: 0.5 candidate
src/newgrf.cpp
--- a/src/newgrf.cpp	Thu Feb 22 08:43:02 2007 +0000
+++ b/src/newgrf.cpp	Thu Feb 22 15:01:38 2007 +0000
@@ -2729,11 +2729,11 @@
 	 *
 	 * V ignored       Anything following the 0C is ignored */
 
-	static char comment[256];
 	if (len == 1) return;
 
-	ttd_strlcpy(comment, (char*)(buf + 1), minu(sizeof(comment), len));
-	grfmsg(2, "GRFComment: %s", comment);
+	int text_len = len - 1;
+	const char *text = (const char*)(buf + 1);
+	grfmsg(2, "GRFComment: %.*s", text_len, text);
 }
 
 /* Action 0x0D (GLS_SAFETYSCAN) */