(svn r7047) -Fix [FS#317]: Zooming out near map-borders would previously fail because the new centre
would be outside the map. Change behaviour so that a reasonable approximation is
returned so that zooming (out) still works (GrimRC)
--- a/viewport.c Thu Nov 02 23:51:05 2006 +0000
+++ b/viewport.c Fri Nov 03 00:48:03 2006 +0000
@@ -297,6 +297,7 @@
{
Point pt;
int a,b;
+ uint z;
if ( (uint)(x -= vp->left) >= (uint)vp->width ||
(uint)(y -= vp->top) >= (uint)vp->height) {
@@ -315,20 +316,20 @@
b = x-y;
#endif
- if ((uint)a < MapMaxX() * TILE_SIZE && (uint)b < MapMaxY() * TILE_SIZE) {
- uint z;
-
- z = GetSlopeZ(a, b ) / 2;
- z = GetSlopeZ(a + z, b + z) / 2;
- z = GetSlopeZ(a + z, b + z) / 2;
- z = GetSlopeZ(a + z, b + z) / 2;
- z = GetSlopeZ(a + z, b + z) / 2;
-
- pt.x = a + z;
- pt.y = b + z;
- } else {
- pt.x = pt.y = -1;
- }
+ /* we need to move variables in to the valid range, as the
+ * GetTileZoomCenterWindow() function can call here with invalid x and/or y,
+ * when the user tries to zoom out along the sides of the map */
+ a = clamp(a, 0, (int)(MapMaxX() * TILE_SIZE) - 1);
+ b = clamp(b, 0, (int)(MapMaxY() * TILE_SIZE) - 1);
+
+ z = GetSlopeZ(a, b ) / 2;
+ z = GetSlopeZ(a + z, b + z) / 2;
+ z = GetSlopeZ(a + z, b + z) / 2;
+ z = GetSlopeZ(a + z, b + z) / 2;
+ z = GetSlopeZ(a + z, b + z) / 2;
+
+ pt.x = a + z;
+ pt.y = b + z;
return pt;
}