(svn r13714) -Fix: remove the unique_id from the message that a client has joined as it is only exposes the unique_id more than needed. Patch by dih.
authorrubidium
Thu, 17 Jul 2008 12:02:09 +0000
changeset 11156 cf146f346724
parent 11155 db49ce10b3b5
child 11157 a0173588b15e
(svn r13714) -Fix: remove the unique_id from the message that a client has joined as it is only exposes the unique_id more than needed. Patch by dih.
src/network/network_client.cpp
src/network/network_server.cpp
--- a/src/network/network_client.cpp	Thu Jul 17 11:47:57 2008 +0000
+++ b/src/network/network_client.cpp	Thu Jul 17 12:02:09 2008 +0000
@@ -400,10 +400,8 @@
 	uint16 index = p->Recv_uint16();
 	PlayerID playas = (Owner)p->Recv_uint8();
 	char name[NETWORK_NAME_LENGTH];
-	char unique_id[NETWORK_UNIQUE_ID_LENGTH];
 
 	p->Recv_string(name, sizeof(name));
-	p->Recv_string(unique_id, sizeof(unique_id));
 
 	if (MY_CLIENT->has_quit) return NETWORK_RECV_STATUS_CONN_LOST;
 
@@ -435,7 +433,6 @@
 		ci->client_playas = playas;
 
 		ttd_strlcpy(ci->client_name, name, sizeof(ci->client_name));
-		ttd_strlcpy(ci->unique_id, unique_id, sizeof(ci->unique_id));
 
 		InvalidateWindow(WC_CLIENT_LIST, 0);
 
--- a/src/network/network_server.cpp	Thu Jul 17 11:47:57 2008 +0000
+++ b/src/network/network_server.cpp	Thu Jul 17 12:02:09 2008 +0000
@@ -49,7 +49,6 @@
 	//    uint16:  The index of the client (always unique on a server. 1 = server)
 	//    uint8:  As which player the client is playing
 	//    String: The name of the client
-	//    String: The unique id of the client
 	//
 
 	if (ci->client_index != NETWORK_EMPTY_INDEX) {
@@ -57,7 +56,6 @@
 		p->Send_uint16(ci->client_index);
 		p->Send_uint8 (ci->client_playas);
 		p->Send_string(ci->client_name);
-		p->Send_string(ci->unique_id);
 
 		cs->Send_Packet(p);
 	}