(svn r7560) -Fix (r2300): p2 is not a PlayerID when creating a new company, but the ClientID (index in _network_client_info). Therefore it was not possible to create a new company if 8 or more clients were connected. Thanks to FlashFF for noticing this bug.
--- a/players.c Tue Dec 26 00:33:07 2006 +0000
+++ b/players.c Tue Dec 26 11:47:31 2006 +0000
@@ -820,9 +820,8 @@
/* This command is only executed in a multiplayer game */
if (!_networking) return CMD_ERROR;
- /* ClientID would be valid up to MAX_CLIENT_INFO, but as it has to be a
- * new player, its valid range is restricted to that of players */
- if (!(flags & DC_EXEC) || !IsValidPlayer((PlayerID)cid)) return 0;
+ /* Has the network client a correct ClientID? */
+ if (!(flags & DC_EXEC) || cid >= MAX_CLIENT_INFO) return 0;
/* Delete multiplayer progress bar */
DeleteWindowById(WC_NETWORK_STATUS_WINDOW, 0);