(svn r11971) -Codechange: use of FOR_ALL_ENGINES/ENGINEIDS_OF_TYPE instead of for-loops
--- a/src/elrail.cpp Thu Jan 24 10:41:12 2008 +0000
+++ b/src/elrail.cpp Thu Jan 24 10:47:44 2008 +0000
@@ -475,7 +475,6 @@
int32 SettingsDisableElrail(int32 p1)
{
- EngineID e_id;
Vehicle *v;
Player *p;
bool disable = (p1 != 0);
@@ -485,8 +484,9 @@
const RailType new_railtype = disable ? RAILTYPE_RAIL : RAILTYPE_ELECTRIC;
/* walk through all train engines */
- for (e_id = 0; e_id < NUM_TRAIN_ENGINES; e_id++) {
- RailVehicleInfo *rv_info = &_rail_vehicle_info[e_id];
+ EngineID eid;
+ FOR_ALL_ENGINEIDS_OF_TYPE(eid, VEH_TRAIN) {
+ RailVehicleInfo *rv_info = &_rail_vehicle_info[eid];
/* if it is an electric rail engine and its railtype is the wrong one */
if (rv_info->engclass == 2 && rv_info->railtype == old_railtype) {
/* change it to the proper one */
--- a/src/engine.cpp Thu Jan 24 10:41:12 2008 +0000
+++ b/src/engine.cpp Thu Jan 24 10:47:44 2008 +0000
@@ -342,10 +342,9 @@
void EnginesMonthlyLoop()
{
- Engine *e;
-
if (_cur_year < YEAR_ENGINE_AGING_STOPS) {
- for (e = _engines; e != endof(_engines); e++) {
+ Engine *e;
+ FOR_ALL_ENGINES(e) {
/* Age the vehicle */
if (e->flags & ENGINE_AVAILABLE && e->age != 0xFFFF) {
e->age++;
--- a/src/oldloader.cpp Thu Jan 24 10:41:12 2008 +0000
+++ b/src/oldloader.cpp Thu Jan 24 10:47:44 2008 +0000
@@ -1636,7 +1636,8 @@
/* Make sure the available engines are really available, otherwise
* we will get a "new vehicle"-spree. */
- for (Engine *e = _engines; e != endof(_engines); e++) {
+ Engine *e;
+ FOR_ALL_ENGINES(e) {
if (_date >= (e->intro_date + 365)) {
e->flags = (e->flags & ~ENGINE_EXCLUSIVE_PREVIEW) | ENGINE_AVAILABLE;
e->player_avail = (byte)-1;