1

/* $Id$ */

     2

     3

/** @file widget.cpp Handling of the default/simple widgets. */

     4

     5

#include "stdafx.h"

     6

#include "openttd.h"

     7

#include "core/math_func.hpp"

     8

#include "company_func.h"

     9

#include "gfx_func.h"

    10

#include "window_gui.h"

    11

#include "window_func.h"

    12

#include "widgets/dropdown_func.h"

    13

    14

#include "table/sprites.h"

    15

#include "table/strings.h"

    16

    17

static const char *UPARROW   = "\xEE\x8A\xA0";

    18

static const char *DOWNARROW = "\xEE\x8A\xAA";

    19

    20

/**

    21

 * Compute the vertical position of the draggable part of scrollbar

    22

 * @param sb     Scrollbar list data

    23

 * @param top    Top position of the scrollbar (top position of the up-button)

    24

 * @param bottom Bottom position of the scrollbar (bottom position of the down-button)

    25

 * @return A Point, with x containing the top coordinate of the draggable part, and

    26

 *                       y containing the bottom coordinate of the draggable part

    27

 */

    28

static Point HandleScrollbarHittest(const Scrollbar *sb, int top, int bottom)

    29

{

    30

	Point pt;

    31

	int height, count, pos, cap;

    32

    33

	top += 10;   // top    points to just below the up-button

    34

	bottom -= 9; // bottom points to top of the down-button

    35

    36

	height = (bottom - top);

    37

    38

	pos = sb->pos;

    39

	count = sb->count;

    40

	cap = sb->cap;

    41

    42

	if (count != 0) top += height * pos / count;

    43

    44

	if (cap > count) cap = count;

    45

	if (count != 0) bottom -= (count - pos - cap) * height / count;

    46

    47

	pt.x = top;

    48

	pt.y = bottom - 1;

    49

	return pt;

    50

}

    51

    52

/** Special handling for the scrollbar widget type.

    53

 * Handles the special scrolling buttons and other

    54

 * scrolling.

    55

 * @param w Window on which a scroll was performed.

    56

 * @param wi Pointer to the scrollbar widget.

    57

 * @param x The X coordinate of the mouse click.

    58

 * @param y The Y coordinate of the mouse click. */

    59

void ScrollbarClickHandler(Window *w, const Widget *wi, int x, int y)

    60

{

    61

	int mi, ma, pos;

    62

	Scrollbar *sb;

    63

    64

	switch (wi->type) {

    65

		case WWT_SCROLLBAR:

    66

			/* vertical scroller */

    67

			w->flags4 &= ~WF_HSCROLL;

    68

			w->flags4 &= ~WF_SCROLL2;

    69

			mi = wi->top;

    70

			ma = wi->bottom;

    71

			pos = y;

    72

			sb = &w->vscroll;

    73

			break;

    74

    75

		case WWT_SCROLL2BAR:

    76

			/* 2nd vertical scroller */

    77

			w->flags4 &= ~WF_HSCROLL;

    78

			w->flags4 |= WF_SCROLL2;

    79

			mi = wi->top;

    80

			ma = wi->bottom;

    81

			pos = y;

    82

			sb = &w->vscroll2;

    83

			break;

    84

    85

		case  WWT_HSCROLLBAR:

    86

			/* horizontal scroller */

    87

			w->flags4 &= ~WF_SCROLL2;

    88

			w->flags4 |= WF_HSCROLL;

    89

			mi = wi->left;

    90

			ma = wi->right;

    91

			pos = x;

    92

			sb = &w->hscroll;

    93

			break;

    94

    95

		default: NOT_REACHED();

    96

	}

    97

	if (pos <= mi + 9) {

    98

		/* Pressing the upper button? */

    99

		w->flags4 |= WF_SCROLL_UP;

   100

		if (_scroller_click_timeout == 0) {

   101

			_scroller_click_timeout = 6;

   102

			if (sb->pos != 0) sb->pos--;

   103

		}

   104

		_left_button_clicked = false;

   105

	} else if (pos >= ma - 10) {

   106

		/* Pressing the lower button? */

   107

		w->flags4 |= WF_SCROLL_DOWN;

   108

   109

		if (_scroller_click_timeout == 0) {

   110

			_scroller_click_timeout = 6;

   111

			if ((byte)(sb->pos + sb->cap) < sb->count)

   112

				sb->pos++;

   113

		}

   114

		_left_button_clicked = false;

   115

	} else {

   116

		Point pt = HandleScrollbarHittest(sb, mi, ma);

   117

   118

		if (pos < pt.x) {

   119

			sb->pos = max(sb->pos - sb->cap, 0);

   120

		} else if (pos > pt.y) {

   121

			sb->pos = min(

   122

				sb->pos + sb->cap,

   123

				max(sb->count - sb->cap, 0)

   124

			);

   125

		} else {

   126

			_scrollbar_start_pos = pt.x - mi - 9;

   127

			_scrollbar_size = ma - mi - 23;

   128

			w->flags4 |= WF_SCROLL_MIDDLE;

   129

			_scrolling_scrollbar = true;

   130

			_cursorpos_drag_start = _cursor.pos;

   131

		}

   132

	}

   133

   134

	w->SetDirty();

   135

}

   136

   137

/** Returns the index for the widget located at the given position

   138

 * relative to the window. It includes all widget-corner pixels as well.

   139

 * @param *w Window to look inside

   140

 * @param  x The Window client X coordinate

   141

 * @param  y The Window client y coordinate

   142

 * @return A widget index, or -1 if no widget was found.

   143

 */

   144

int GetWidgetFromPos(const Window *w, int x, int y)

   145

{

   146

	uint index;

   147

	int found_index = -1;

   148

   149

	/* Go through the widgets and check if we find the widget that the coordinate is

   150

	 * inside. */

   151

	for (index = 0; index < w->widget_count; index++) {

   152

		const Widget *wi = &w->widget[index];

   153

		if (wi->type == WWT_EMPTY || wi->type == WWT_FRAME) continue;

   154

   155

		if (x >= wi->left && x <= wi->right && y >= wi->top &&  y <= wi->bottom &&

   156

				!w->IsWidgetHidden(index)) {

   157

			found_index = index;

   158

		}

   159

	}

   160

   161

	return found_index;

   162

}

   163

   164

/**

   165

 * Draw frame rectangle.

   166

 * @param left   Left edge of the frame

   167

 * @param top    Top edge of the frame

   168

 * @param right  Right edge of the frame

   169

 * @param bottom Bottom edge of the frame

   170

 * @param color  Colour table to use. @see _colour_gradient

   171

 * @param flags  Flags controlling how to draw the frame. @see FrameFlags

   172

 */

   173

void DrawFrameRect(int left, int top, int right, int bottom, int color, FrameFlags flags)

   174

{

   175

	uint dark         = _colour_gradient[color][3];

   176

	uint medium_dark  = _colour_gradient[color][5];

   177

	uint medium_light = _colour_gradient[color][6];

   178

	uint light        = _colour_gradient[color][7];

   179

   180

	if (flags & FR_TRANSPARENT) {

   181

		GfxFillRect(left, top, right, bottom, PALETTE_TO_TRANSPARENT, FILLRECT_RECOLOR);

   182

	} else {

   183

		uint interior;

   184

   185

		if (flags & FR_LOWERED) {

   186

			GfxFillRect(left,     top,     left,  bottom,     dark);

   187

			GfxFillRect(left + 1, top,     right, top,        dark);

   188

			GfxFillRect(right,    top + 1, right, bottom - 1, light);

   189

			GfxFillRect(left + 1, bottom,  right, bottom,     light);

   190

			interior = (flags & FR_DARKENED ? medium_dark : medium_light);

   191

		} else {

   192

			GfxFillRect(left,     top,    left,      bottom - 1, light);

   193

			GfxFillRect(left + 1, top,    right - 1, top,        light);

   194

			GfxFillRect(right,    top,    right,     bottom - 1, dark);

   195

			GfxFillRect(left,     bottom, right,     bottom,     dark);

   196

			interior = medium_dark;

   197

		}

   198

		if (!(flags & FR_BORDERONLY)) {

   199

			GfxFillRect(left + 1, top + 1, right - 1, bottom - 1, interior);

   200

		}

   201

	}

   202

}

   203

   204

   205

/**

   206

 * Paint all widgets of a window.

   207

 */

   208

void Window::DrawWidgets() const

   209

{

   210

	const DrawPixelInfo* dpi = _cur_dpi;

   211

   212

	for (uint i = 0; i < this->widget_count; i++) {

   213

		const Widget *wi = &this->widget[i];

   214

		bool clicked = this->IsWidgetLowered(i);

   215

		Rect r;

   216

   217

		if (dpi->left > (r.right = wi->right) ||

   218

				dpi->left + dpi->width <= (r.left = wi->left) ||

   219

				dpi->top > (r.bottom = wi->bottom) ||

   220

				dpi->top + dpi->height <= (r.top = wi->top) ||

   221

				this->IsWidgetHidden(i)) {

   222

			continue;

   223

		}

   224

   225

		switch (wi->type & WWT_MASK) {

   226

		case WWT_IMGBTN:

   227

		case WWT_IMGBTN_2: {

   228

			SpriteID img = wi->data;

   229

			assert(img != 0);

   230

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   231

   232

			/* show different image when clicked for WWT_IMGBTN_2 */

   233

			if ((wi->type & WWT_MASK) == WWT_IMGBTN_2 && clicked) img++;

   234

			DrawSprite(img, PAL_NONE, r.left + 1 + clicked, r.top + 1 + clicked);

   235

			break;

   236

		}

   237

   238

		case WWT_PANEL:

   239

			assert(wi->data == 0);

   240

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   241

			break;

   242

   243

		case WWT_EDITBOX:

   244

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, FR_LOWERED | FR_DARKENED);

   245

			break;

   246

   247

		case WWT_TEXTBTN:

   248

		case WWT_TEXTBTN_2:

   249

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   250

			/* FALL THROUGH */

   251

   252

		case WWT_LABEL: {

   253

			StringID str = wi->data;

   254

   255

			if ((wi->type & WWT_MASK) == WWT_TEXTBTN_2 && clicked) str++;

   256

   257

			DrawStringCentered(((r.left + r.right + 1) >> 1) + clicked, ((r.top + r.bottom + 1) >> 1) - 5 + clicked, str, TC_FROMSTRING);

   258

			break;

   259

		}

   260

   261

		case WWT_TEXT: {

   262

			const StringID str = wi->data;

   263

   264

			if (str != STR_NULL) DrawStringTruncated(r.left, r.top, str, wi->color, r.right - r.left);

   265

			break;

   266

		}

   267

   268

		case WWT_INSET: {

   269

			const StringID str = wi->data;

   270

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, FR_LOWERED | FR_DARKENED);

   271

   272

			if (str != STR_NULL) DrawStringTruncated(r.left + 2, r.top + 1, str, TC_FROMSTRING, r.right - r.left - 10);

   273

			break;

   274

		}

   275

   276

		case WWT_MATRIX: {

   277

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   278

   279

			int c = GB(wi->data, 0, 8);

   280

			int amt1 = (wi->right - wi->left + 1) / c;

   281

   282

			int d = GB(wi->data, 8, 8);

   283

			int amt2 = (wi->bottom - wi->top + 1) / d;

   284

   285

			int color = _colour_gradient[wi->color & 0xF][6];

   286

   287

			int x = r.left;

   288

			for (int ctr = c; ctr > 1; ctr--) {

   289

				x += amt1;

   290

				GfxFillRect(x, r.top + 1, x, r.bottom - 1, color);

   291

			}

   292

   293

			x = r.top;

   294

			for (int ctr = d; ctr > 1; ctr--) {

   295

				x += amt2;

   296

				GfxFillRect(r.left + 1, x, r.right - 1, x, color);

   297

			}

   298

   299

			color = _colour_gradient[wi->color & 0xF][4];

   300

   301

			x = r.left - 1;

   302

			for (int ctr = c; ctr > 1; ctr--) {

   303

				x += amt1;

   304

				GfxFillRect(x, r.top + 1, x, r.bottom - 1, color);

   305

			}

   306

   307

			x = r.top - 1;

   308

			for (int ctr = d; ctr > 1; ctr--) {

   309

				x += amt2;

   310

				GfxFillRect(r.left + 1, x, r.right - 1, x, color);

   311

			}

   312

   313

			break;

   314

		}

   315

   316

		/* vertical scrollbar */

   317

		case WWT_SCROLLBAR: {

   318

			assert(wi->data == 0);

   319

			assert(r.right - r.left == 11); // To ensure the same sizes are used everywhere!

   320

   321

			/* draw up/down buttons */

   322

			clicked = ((this->flags4 & (WF_SCROLL_UP | WF_HSCROLL | WF_SCROLL2)) == WF_SCROLL_UP);

   323

			DrawFrameRect(r.left, r.top, r.right, r.top + 9, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   324

			DoDrawString(UPARROW, r.left + 2 + clicked, r.top + clicked, TC_BLACK);

   325

   326

			clicked = (((this->flags4 & (WF_SCROLL_DOWN | WF_HSCROLL | WF_SCROLL2)) == WF_SCROLL_DOWN));

   327

			DrawFrameRect(r.left, r.bottom - 9, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   328

			DoDrawString(DOWNARROW, r.left + 2 + clicked, r.bottom - 9 + clicked, TC_BLACK);

   329

   330

			int c1 = _colour_gradient[wi->color & 0xF][3];

   331

			int c2 = _colour_gradient[wi->color & 0xF][7];

   332

   333

			/* draw "shaded" background */

   334

			GfxFillRect(r.left, r.top + 10, r.right, r.bottom - 10, c2);

   335

			GfxFillRect(r.left, r.top + 10, r.right, r.bottom - 10, c1, FILLRECT_CHECKER);

   336

   337

			/* draw shaded lines */

   338

			GfxFillRect(r.left + 2, r.top + 10, r.left + 2, r.bottom - 10, c1);

   339

			GfxFillRect(r.left + 3, r.top + 10, r.left + 3, r.bottom - 10, c2);

   340

			GfxFillRect(r.left + 7, r.top + 10, r.left + 7, r.bottom - 10, c1);

   341

			GfxFillRect(r.left + 8, r.top + 10, r.left + 8, r.bottom - 10, c2);

   342

   343

			Point pt = HandleScrollbarHittest(&this->vscroll, r.top, r.bottom);

   344

			DrawFrameRect(r.left, pt.x, r.right, pt.y, wi->color, (this->flags4 & (WF_SCROLL_MIDDLE | WF_HSCROLL | WF_SCROLL2)) == WF_SCROLL_MIDDLE ? FR_LOWERED : FR_NONE);

   345

			break;

   346

		}

   347

   348

		case WWT_SCROLL2BAR: {

   349

			assert(wi->data == 0);

   350

			assert(r.right - r.left == 11); // To ensure the same sizes are used everywhere!

   351

   352

			/* draw up/down buttons */

   353

			clicked = ((this->flags4 & (WF_SCROLL_UP | WF_HSCROLL | WF_SCROLL2)) == (WF_SCROLL_UP | WF_SCROLL2));

   354

			DrawFrameRect(r.left, r.top, r.right, r.top + 9, wi->color,  (clicked) ? FR_LOWERED : FR_NONE);

   355

			DoDrawString(UPARROW, r.left + 2 + clicked, r.top + clicked, TC_BLACK);

   356

   357

			clicked = ((this->flags4 & (WF_SCROLL_DOWN | WF_HSCROLL | WF_SCROLL2)) == (WF_SCROLL_DOWN | WF_SCROLL2));

   358

			DrawFrameRect(r.left, r.bottom - 9, r.right, r.bottom, wi->color,  (clicked) ? FR_LOWERED : FR_NONE);

   359

			DoDrawString(DOWNARROW, r.left + 2 + clicked, r.bottom - 9 + clicked, TC_BLACK);

   360

   361

			int c1 = _colour_gradient[wi->color & 0xF][3];

   362

			int c2 = _colour_gradient[wi->color & 0xF][7];

   363

   364

			/* draw "shaded" background */

   365

			GfxFillRect(r.left, r.top + 10, r.right, r.bottom - 10, c2);

   366

			GfxFillRect(r.left, r.top + 10, r.right, r.bottom - 10, c1, FILLRECT_CHECKER);

   367

   368

			/* draw shaded lines */

   369

			GfxFillRect(r.left + 2, r.top + 10, r.left + 2, r.bottom - 10, c1);

   370

			GfxFillRect(r.left + 3, r.top + 10, r.left + 3, r.bottom - 10, c2);

   371

			GfxFillRect(r.left + 7, r.top + 10, r.left + 7, r.bottom - 10, c1);

   372

			GfxFillRect(r.left + 8, r.top + 10, r.left + 8, r.bottom - 10, c2);

   373

   374

			Point pt = HandleScrollbarHittest(&this->vscroll2, r.top, r.bottom);

   375

			DrawFrameRect(r.left, pt.x, r.right, pt.y, wi->color, (this->flags4 & (WF_SCROLL_MIDDLE | WF_HSCROLL | WF_SCROLL2)) == (WF_SCROLL_MIDDLE | WF_SCROLL2) ? FR_LOWERED : FR_NONE);

   376

			break;

   377

		}

   378

   379

		/* horizontal scrollbar */

   380

		case WWT_HSCROLLBAR: {

   381

			assert(wi->data == 0);

   382

			assert(r.bottom - r.top == 11); // To ensure the same sizes are used everywhere!

   383

   384

			clicked = ((this->flags4 & (WF_SCROLL_UP | WF_HSCROLL)) == (WF_SCROLL_UP | WF_HSCROLL));

   385

			DrawFrameRect(r.left, r.top, r.left + 9, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   386

			DrawSprite(SPR_ARROW_LEFT, PAL_NONE, r.left + 1 + clicked, r.top + 1 + clicked);

   387

   388

			clicked = ((this->flags4 & (WF_SCROLL_DOWN | WF_HSCROLL)) == (WF_SCROLL_DOWN | WF_HSCROLL));

   389

			DrawFrameRect(r.right - 9, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   390

			DrawSprite(SPR_ARROW_RIGHT, PAL_NONE, r.right - 8 + clicked, r.top + 1 + clicked);

   391

   392

			int c1 = _colour_gradient[wi->color & 0xF][3];

   393

			int c2 = _colour_gradient[wi->color & 0xF][7];

   394

   395

			/* draw "shaded" background */

   396

			GfxFillRect(r.left + 10, r.top, r.right - 10, r.bottom, c2);

   397

			GfxFillRect(r.left + 10, r.top, r.right - 10, r.bottom, c1, FILLRECT_CHECKER);

   398

   399

			/* draw shaded lines */

   400

			GfxFillRect(r.left + 10, r.top + 2, r.right - 10, r.top + 2, c1);

   401

			GfxFillRect(r.left + 10, r.top + 3, r.right - 10, r.top + 3, c2);

   402

			GfxFillRect(r.left + 10, r.top + 7, r.right - 10, r.top + 7, c1);

   403

			GfxFillRect(r.left + 10, r.top + 8, r.right - 10, r.top + 8, c2);

   404

   405

			/* draw actual scrollbar */

   406

			Point pt = HandleScrollbarHittest(&this->hscroll, r.left, r.right);

   407

			DrawFrameRect(pt.x, r.top, pt.y, r.bottom, wi->color, (this->flags4 & (WF_SCROLL_MIDDLE | WF_HSCROLL)) == (WF_SCROLL_MIDDLE | WF_HSCROLL) ? FR_LOWERED : FR_NONE);

   408

   409

			break;

   410

		}

   411

   412

		case WWT_FRAME: {

   413

			const StringID str = wi->data;

   414

			int x2 = r.left; // by default the left side is the left side of the widget

   415

   416

			if (str != STR_NULL) x2 = DrawString(r.left + 6, r.top, str, TC_FROMSTRING);

   417

   418

			int c1 = _colour_gradient[wi->color][3];

   419

			int c2 = _colour_gradient[wi->color][7];

   420

   421

			/* Line from upper left corner to start of text */

   422

			GfxFillRect(r.left, r.top + 4, r.left + 4, r.top + 4, c1);

   423

			GfxFillRect(r.left + 1, r.top + 5, r.left + 4, r.top + 5, c2);

   424

   425

			/* Line from end of text to upper right corner */

   426

			GfxFillRect(x2, r.top + 4, r.right - 1, r.top + 4, c1);

   427

			GfxFillRect(x2, r.top + 5, r.right - 2, r.top + 5, c2);

   428

   429

			/* Line from upper left corner to bottom left corner */

   430

			GfxFillRect(r.left, r.top + 5, r.left, r.bottom - 1, c1);

   431

			GfxFillRect(r.left + 1, r.top + 6, r.left + 1, r.bottom - 2, c2);

   432

   433

			/*Line from upper right corner to bottom right corner */

   434

			GfxFillRect(r.right - 1, r.top + 5, r.right - 1, r.bottom - 2, c1);

   435

			GfxFillRect(r.right, r.top + 4, r.right, r.bottom - 1, c2);

   436

   437

			GfxFillRect(r.left + 1, r.bottom - 1, r.right - 1, r.bottom - 1, c1);

   438

			GfxFillRect(r.left, r.bottom, r.right, r.bottom, c2);

   439

   440

			break;

   441

		}

   442

   443

		case WWT_STICKYBOX:

   444

			assert(wi->data == 0);

   445

			assert(r.right - r.left == 11); // To ensure the same sizes are used everywhere!

   446

   447

			clicked = !!(this->flags4 & WF_STICKY);

   448

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   449

			DrawSprite((clicked) ? SPR_PIN_UP : SPR_PIN_DOWN, PAL_NONE, r.left + 2 + clicked, r.top + 3 + clicked);

   450

			break;

   451

   452

		case WWT_RESIZEBOX:

   453

			assert(wi->data == 0);

   454

			assert(r.right - r.left == 11); // To ensure the same sizes are used everywhere!

   455

   456

			clicked = !!(this->flags4 & WF_SIZING);

   457

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, (clicked) ? FR_LOWERED : FR_NONE);

   458

			DrawSprite(SPR_WINDOW_RESIZE, PAL_NONE, r.left + 3 + clicked, r.top + 3 + clicked);

   459

			break;

   460

   461

		case WWT_CLOSEBOX: {

   462

			const StringID str = wi->data;

   463

   464

			assert(str == STR_00C5 || str == STR_00C6); // black or silver cross

   465

			assert(r.right - r.left == 10); // To ensure the same sizes are used everywhere

   466

   467

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, FR_NONE);

   468

			DrawString(r.left + 2, r.top + 2, str, TC_FROMSTRING);

   469

			break;

   470

		}

   471

   472

		case WWT_CAPTION:

   473

			assert(r.bottom - r.top == 13); // To ensure the same sizes are used everywhere!

   474

			DrawFrameRect(r.left, r.top, r.right, r.bottom, wi->color, FR_BORDERONLY);

   475

			DrawFrameRect(r.left + 1, r.top + 1, r.right - 1, r.bottom - 1, wi->color, (this->caption_color == 0xFF) ? FR_LOWERED | FR_DARKENED : FR_LOWERED | FR_DARKENED | FR_BORDERONLY);

   476

   477

			if (this->caption_color != 0xFF) {

   478

				GfxFillRect(r.left + 2, r.top + 2, r.right - 2, r.bottom - 2, _colour_gradient[_company_colours[this->caption_color]][4]);

   479

			}

   480

   481

			DrawStringCenteredTruncated(r.left + 2, r.right - 2, r.top + 2, wi->data, TC_FROMSTRING);

   482

			break;

   483

   484

		case WWT_DROPDOWN: {

   485

			assert(r.bottom - r.top == 11); // ensure consistent size