(svn r8120) -Fix (r8055): Station cargo waiting value clamp should be signed not unsigned. This resulted in cargo magically appearing...
--- a/src/station_cmd.cpp Sun Jan 14 17:17:30 2007 +0000
+++ b/src/station_cmd.cpp Sun Jan 14 18:38:40 2007 +0000
@@ -2524,8 +2524,8 @@
// if rating is <= 127 and there are any items waiting, maybe remove some goods.
if (rating <= 127 && waiting != 0) {
uint32 r = Random();
- if ( (uint)rating <= (r & 0x7F) ) {
- waiting = max(waiting - ((r >> 8)&3) - 1, 0U);
+ if (rating <= (int)GB(r, 0, 7)) {
+ waiting = max(waiting - (int)GB(r, 8, 2) - 1, 0);
waiting_changed = true;
}
}